feat: support design tokens and paragon 23 #279
Conversation
dcoa
force-pushed
the
dcoa/design-tokens-support
branch
from
89d5172 to
6d8727c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master-design-tokens #279 +/- ##
=====================================================
Coverage 89.29% 89.29%
=====================================================
Files 143 143
Lines 2205 2205
Branches 452 452
=====================================================
Hits 1969 1969
Misses 226 226
Partials 10 10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dcoa
force-pushed
the
dcoa/design-tokens-support
branch
from
6d8727c to
b662f8c
Compare
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @dcoa! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
dcoa
force-pushed
the
dcoa/design-tokens-support
branch
from
b662f8c to
7713ed1
Compare
dcoa
changed the title
dcoa
force-pushed
the
dcoa/design-tokens-support
branch
from
7713ed1 to
9ff8fec
Compare
src/components/ModalContainer.scss
Outdated
| .ora-modal-body { | ||
| min-height: calc(100vh - 20px - 64px - (map-get($spacers, 2) * 8)); | ||
| min-height: calc(100vh - 20px - 64px - calc(var(--pgn-spacing-spacer-3) * 8)); |
There was a problem hiding this comment.
Looks like this was 2 (map-get($spacers, 2) before and now it's 3 calc(var(--pgn-spacing-spacer-3) - is that intentional?
| } | ||
|
|
||
| .assessment-col { | ||
| min-width: 300px; | ||
| } | ||
| } | ||
|
|
||
| @include media-breakpoint-down(sm) { | ||
| @media (--pgn-size-breakpoint-max-width-sm) { |
There was a problem hiding this comment.
| @media (--pgn-size-breakpoint-max-width-sm) { | |
| @media (--pgn-size-breakpoint-max-width-sm) { |
src/views/GradeView/index.scss
Outdated
| flex-wrap: nowrap !important; | ||
| gap: 1em; | ||
| } | ||
|
|
||
| @include media-breakpoint-down(md) { | ||
| @media (--pgn-size-breakpoint-max-width-md) { |
There was a problem hiding this comment.
| @media (--pgn-size-breakpoint-max-width-md) { | |
| @media (--pgn-size-breakpoint-max-width-md) { |
dcoa
force-pushed
the
dcoa/design-tokens-support
branch
from
9ff8fec to
da9bfea
Compare
brian-smith-tcril
merged commit bd19a3b
into
openedx:master-design-tokens
Warning
This PR should not be merge to
masterdirectly, it should point tomaster-design-tokensonce the branch has been created.This PR updates frontend app ora to support CSS variables and the corresponding paragon design tokens.
Changes implemented
Important
This PR requires a compatible version with paragon 23 of dependencies because of that the following PRs need to be merged first: